fix, updates lastN after exiting the pip mode #10491
Conversation
|
Hi, thanks for your contribution! |
|
Jenkins please test this please. |
|
Hi, it is updated. @saghul |
|
Jenkins please test this please. |
|
Sorry for the delay. I'm looking at this now, and while I can repro I don't understand where the breakage comes from. When you go into PiP mode then we detect reduced UI mode, then disable the filmstrip, which yields a last N value of 1. When we come back we reverse that, so that code path should no longer be taken and as a result we should not override it with 1. I think this PR is overly complicated to fix the issue at hand. |
If last N goes down to 1 it will be stuck there since it's > 0 and will be our `lastNSelected`. When limits are applied we'll take the minimum, so it will end up being 1. Once can end up in last N being 1 by several means, the more obvious one by entering Picture-in-Picture mode on mobile. Fix it by not using the previous last N value for the current calculation, at all. Fixes: jitsi#10257 Closes: jitsi#10491
If last N goes down to 1 it will be stuck there since it's > 0 and will be our `lastNSelected`. When limits are applied we'll take the minimum, so it will end up being 1. Once can end up in last N being 1 by several means, the more obvious one by entering Picture-in-Picture mode on mobile. Fix it by not using the previous last N value for the current calculation, at all. Fixes: #10257 Closes: #10491
The separation between config_last_n and applied_last_n was meant to preserve the functionality of videoQualitySlider, which I believe might have been broken by #11425 . |
|
You might be right, we have changed how the video quality slider operates a couple of times. In that case I'd say incorporating the video slider value into the computation is probably the way to go. |
If last N goes down to 1 it will be stuck there since it's > 0 and will be our `lastNSelected`. When limits are applied we'll take the minimum, so it will end up being 1. Once can end up in last N being 1 by several means, the more obvious one by entering Picture-in-Picture mode on mobile. Fix it by not using the previous last N value for the current calculation, at all. Fixes: #10257 Closes: #10491
This change is regarding the Issue #10257 reported by @lultimouomo.
It separates the applicable last-n and the one that is configurable by the last-n configuration features, such as VideoQualitySlider or potentially any other feature. By doing so, it triggers Lastn/middleware to recalculate a new last-n as needed.