fix(lastN) fix last N getting stuck on 1 #11425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If last N goes down to 1 it will be stuck there since it's > 0 and will be our `lastNSelected`. When limits are applied we'll take the minimum, so it will end up being 1. Once can end up in last N being 1 by several means, the more obvious one by entering Picture-in-Picture mode on mobile. Fix it by not using the previous last N value for the current calculation, at all. Fixes: jitsi#10257 Closes: jitsi#10491
jallamsetty1
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If last N goes down to 1 it will be stuck there since it's > 0 and will
be our
lastNSelected. When limits are applied we'll take the minimum,so it will end up being 1.
Once can end up in last N being 1 by several means, the more obvious one
by entering Picture-in-Picture mode on mobile.
Fix it by not using the previous last N value for the current
calculation, at all.
Fixes: #10257
Closes: #10491