rn: add native loggers #4579
Merged
rn: add native loggers #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
force-pushed
the
native-log
branch
5 times, most recently
from
e3a3546
to
7fd0688
Compare
paweldomas
requested changes
Sep 3, 2019
android/sdk/src/main/java/org/jitsi/meet/sdk/ConnectionService.java
Outdated
Show resolved
Hide resolved
android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetUncaughtExceptionHandler.java
Outdated
Show resolved
Hide resolved
android/sdk/src/main/java/org/jitsi/meet/sdk/WiFiStatsModule.java
Outdated
Show resolved
Hide resolved
|
I was also thinking that |
|
@paweldomas Updated, PTAL! |
These provide the ability to integrate the SDK with some other application loggers. At the time this was written we use Timber on Android and CocoaLumberjack on iOS. In addition to the integration capabilities, a LogBridge React Native module provides log transports for JavaScript code, thus centralizing all logs on the native loggers.
|
@paweldomas Updated again! |
paweldomas
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These provide the ability to integrate the SDK with some other application
loggers.
At the time this was written we use Timer on Android and CocoaLumberjack on iOS.
In addition to the integration capabilities, a LogBridge React Native module
provides log transports for JavaScript code, thus centralizing all logs on the
native loggers.
TODO