Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-ui): specify the correct keyboard type and content on iOS so autocomplete and keyboards work correctly #6555

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

monkeydom
Copy link
Contributor

With this change the display name and email fields provide proper autocomplete suggestion based on your address book.

Also the Server URL field will show the URL keyboard (having shortcuts for .com and such)

…so autocomplete and keyboards work correctly
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

saghul
saghul previously approved these changes May 4, 2020
@saghul
Copy link
Member

saghul commented May 4, 2020

Changes look good, thanks @monkeydom ! Have you signed the CLA?

@monkeydom
Copy link
Contributor Author

Yes, I signed the iCLA before making any contributions.

@Echolon Echolon added ios Issue related to the iPhone/iPad operating system mobile Issue related to any mobile system running Jitsi Meet ui/ux User Interface / User Experience related issues labels May 27, 2020
@saghul
Copy link
Member

saghul commented Jul 21, 2020

Jenkins please test this please

@saghul saghul merged commit 48a58f8 into jitsi:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ios Issue related to the iPhone/iPad operating system mobile Issue related to any mobile system running Jitsi Meet ui/ux User Interface / User Experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants