[Debian package] Move launcher to /usr/bin #502
Conversation
The renaming maybe missed in deb-src target.
Also, use glob classpath, it is supported since Java 6.
The renaming maybe missed in deb-src target.
Also, use glob classpath, it is supported since Java 6.
|
Hi, thanks for your contribution! |
| <chmod perm="755"> | ||
| <fileset dir="${debian.dir}/usr/bin"></fileset> | ||
| </chmod> | ||
|
|
There was a problem hiding this comment.
Why you need to touch some system folder permissions which are not jvb related.
There was a problem hiding this comment.
You're right, I just did this for no reason.
| libs="$SCRIPT_DIR/lib/native/linux-64" | ||
| logging_config="$SCRIPT_DIR/lib/logging.properties" | ||
| videobridge_rc="$SCRIPT_DIR/lib/videobridge.rc" | ||
| cp="$BASE_LIB_DIR/*:$BASE_LIB_DIR/lib/*" |
There was a problem hiding this comment.
I think cp was containing a list of jars and not star paths, not sure whether the later works.
There was a problem hiding this comment.
See http://docs.oracle.com/javase/8/docs/technotes/tools/unix/classpath.html#A1100762
and specifically:
Class path entries can contain the base name wildcard character (*), which is considered equivalent to specifying a list of all of the files in the directory with the extension .jar or .JAR
There was a problem hiding this comment.
I think I've been experiencing this problem and I think there is a reason that current -cp behave like this. Have you tested this?
|
Errr, I'm sorry to say that I don't have the time and the incentive to work on this anymore. I hope that you preferred to be notified on this rather than nothing. I can close it if you like. |
|
This is now obsolete, please re-open if it's still needed. |
Starts to work on #497.
The launcher is moved from
/usr/share/jitsi-videobridge/jvb.shinto/usr/bin/jvb.This is far from perfect, since it only works for linux-64, but I want to gather comments before going on.
If the way to do it seems wrong, please raise your hand.
(Sorry for other commits, I've rebased too late)