fix(TPC): replace isFirefox with feature

jitsi · Feb 27, 2017 · 6981601 · 6981601
1 parent a424955
commit 6981601
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/modules/RTC/RTCBrowserType.js b/modules/RTC/RTCBrowserType.js
@@ -24,6 +24,17 @@ var RTCBrowserType = {
 
     RTC_BROWSER_REACT_NATIVE: "rtc_browser.react-native",
 
+    /**
+     * Tells whether or not the <tt>MediaStream/tt> is removed from
+     * the <tt>PeerConnection</tt> and disposed on video mute (in order to turn
+     * off the camera device).
+     * @return {boolean} <tt>true</tt> if the current browser supports this
+     * strategy or <tt>false</tt> otherwise.
+     */
+    doesVideoMuteByStreamRemove: function () {
+        return !RTCBrowserType.isFirefox();
+    },
+
     /**
      * Gets current browser type.
      * @returns {string}

diff --git a/modules/RTC/TraceablePeerConnection.js b/modules/RTC/TraceablePeerConnection.js
@@ -941,12 +941,11 @@ var getters = {
                 dumpSDP(desc));
         }
 
-        // FIXME replace with a feature
-        if (!RTCBrowserType.isFirefox()) {
+        if (RTCBrowserType.doesVideoMuteByStreamRemove()) {
             this.mungeLocalSdp.maybeMungeLocalSdp(desc);
             logger.debug(
                 'getLocalDescription::postTransform '
-                    + '(local video mute hack)', desc);
+                    + '(munge local SDP)', desc);
         }
 
         return desc ? desc : {};