-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making a room password protected #512
Comments
guusdk
added a commit
to guusdk/lib-jitsi-meet
that referenced
this issue
Jun 17, 2017
When modifying the room protection (setting or unsetting a password), the muc#roomconfig_passwordprotectedroom should always be defined. This fixes issue jitsi#512.
This was referenced Jun 17, 2017
guusdk
added a commit
to guusdk/lib-jitsi-meet
that referenced
this issue
May 30, 2018
When modifying the room protection (setting or unsetting a password), the muc#roomconfig_passwordprotectedroom should always be defined. This fixes issue jitsi#512.
Today I set up Jitsi Meet with ejabberd, and I have exactly this same problem: |
paweldomas
pushed a commit
that referenced
this issue
Apr 6, 2020
When modifying the room protection (setting or unsetting a password), the muc#roomconfig_passwordprotectedroom should always be defined. This fixes issue #512.
paweldomas
pushed a commit
that referenced
this issue
Apr 6, 2020
When modifying the room protection (setting or unsetting a password), the muc#roomconfig_passwordprotectedroom should always be defined. This fixes issue #512.
Note that the mobile apps are still not updated so they can't setup a password yet :( |
They have been updated already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
XEP-0045 defines two
room_config
fields that relate to the password protection of a room:Prosody appears to work with only the latter, while Openfire requires you to set both, and will not make the room password protected when setting only the
roomsecret
field.Arguably, setting the room password implies that a user wants the the room to be password protected (which is raised as an Openfire issue here, but the specification is somewhat confusing at this point (as discussed here)
At some point, the original author of the code wondered about this behavior, given the 'fixme' comment left at https://github.com/jitsi/lib-jitsi-meet/blob/master/modules/xmpp/ChatRoom.js#L857
To be safe, the client should always set both values - that will always have the desired effect, no matter what interpretation is implemented server-sided.
The text was updated successfully, but these errors were encountered: