ref(JitsiConference): don't crash on wrong oldTrack #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If oldTrack was not previously in the conference this will lead to a crash in onLocalTrackRemoved where oldTrack doesn't have `muteHandler` and `audioLevelHandler` listeners defined.
|
It's either that or the method should throw a meaningful error. @saghul @jallamsetty1 WDYT? |
|
Maybe we can just print a warning as in "this may be fine if you know what you're doing" |
| // First do the removal of the oldTrack at the JitsiConference level | ||
| if (oldTrack) { | ||
| if (oldTrackBelongsToConference) { |
There was a problem hiding this comment.
Can we print an error if the oldTrack is not null and it doesn't belong to the conference ?
jallamsetty1
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If oldTrack was not previously in the conference this will
lead to a crash in onLocalTrackRemoved where oldTrack doesn't
have
muteHandlerandaudioLevelHandlerlisteners defined.