Fix codec renegotiation and reverse the order of the ssrcs being signaled from Firefox to Jicofo. #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated codec. If Jicofo doesn't offer VP9 but the client expresses a preference for VP9, VP9 bitrates were being imposed before.
modules/sdp/SDP.js
Outdated
| if (browser.isFirefox() && simGroup) { | ||
| // Use the first ssrc from the SIM group since the order of the SSRCs need to be reversed for Firefox. | ||
| ssrc = simGroup.substring(17).split(' ')[0]; | ||
| } | ||
| ssrc = assrcline.substring(7).split(' ')[0]; // take the first |
There was a problem hiding this comment.
Don't you need an else here? It looks like the second ssrc assignment overrides the first.
There was a problem hiding this comment.
🤦♀️ I thought I did that but wonder how the test I ran was showing the correct ssrcs in the signaling ..
There was a problem hiding this comment.
@JonathanLennox fixed it.
This fixes an issue where the bridge doesn't forward the HD stream from Firefox to other users in the call. The order of the ssrcs produced by the browser is from Highest resolution to lowest whereas the bridge assumes it to be from lowest to highest as is the case in Chrome and Safari.
jallamsetty1
force-pushed
the
fix-codeco-renegotiaiton
branch
from
b33f2f6
to
c85f484
Compare
damencho
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impose VP9 bitrates only when VP9 is negotiated. If Jicofo doesn't offer VP9 but the client expresses a preference for VP9, VP9 bitrates were being imposed before.
This fixes an issue where the bridge doesn't forward the HD stream from Firefox to other users in the call. The order of the ssrcs produced by the browser is from Highest resolution to lowest whereas the bridge assumes it to be from lowest to highest as is the case with Chrome and Safari.