Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When user leaves conference, and there are no other members, timeout … #840

Closed
wants to merge 1 commit into from

Conversation

golyo
Copy link

@golyo golyo commented Dec 4, 2018

When user leaves conference, and there are no other members, timeout error occures.

@golyo golyo mentioned this pull request Dec 4, 2018
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@sapkra
Copy link
Contributor

sapkra commented Oct 5, 2020

Already seems to be fixed in master:

if (isSelfPresence) {
// If the status code is 110 this means we're leaving and we would
// like to remove everyone else from our view, so we trigger the
// event.
membersKeys.forEach(jid => {
const member = this.members[jid];
delete this.members[jid];
this.onParticipantLeft(jid, member.isFocus);
});
this.connection.emuc.doLeave(this.roomjid);
// we fire muc_left only if this is not a kick,
// kick has both statuses 110 and 307.
if (!isKick) {
this.eventEmitter.emit(XMPPEvents.MUC_LEFT);
}
} else {
delete this.members[from];
this.onParticipantLeft(from, false);
}

@sapkra sapkra closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants