Dtls sctp fixes #144
Merged
Dtls sctp fixes #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing the length without taking grow() into account may is certain situations (when the DatagramTransportImpl has already queued a longer packet) lead in failure of the receive() call.
Reads all available application data from the DTLS transport, as opposed to just a single datagram. This works around an issue causing the SCTP connection in jitsi-videobridge to be delayed by around 13 seconds (until the SCTP client retransmits the COOKIE-ECHO part of the handshake). A race condition between the DTLS connect thread and the SCTP thread of jitsi-videobridge would result in a packet left in DatagramTransportImpl's queue and not immediately decoded and returned to SCTP. This packet would only be read when the next DTLS packet was received (at which time this new packet was queued and not processed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.