Use fixed Random seed values and a latch for test consistency. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Communicate that testing is happening and differentiate test outcomes. Tried a couple of fixed seed values that would still exercise the tests but complete in under a minute on my machine. Test consistently passes and in a reasonable amount of time. Formatting.
|
Can one of the admins verify this patch? |
|
@ibauersachs Was the formatting from #77 only about braces and then I did too much reformatting? I now realize should have asked which formatting was in violation, but I figured you all are very busy. |
|
Not sure anymore, at first glance now I just saw braces. Here's a link to the convention: https://jitsi.org/Documentation/CodeConvention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Communicate that testing is happening and differentiate test outcomes.
Tried a couple of fixed seed values that would still exercise the
tests but complete in under a minute on my machine.
Test consistently passes and in a reasonable amount of time.
Formatting.
This PR is a replacement for #77 (when force pushing updates to that branch, all the comments disappeared).