New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untranslated Original Lyrics Lines not Showing in Translated Lyrics in Certain Lyrics Modes #108

Closed

daoxi opened this issue Jul 11, 2022 · 1 comment

Assignees

Labels

bug

Contributor

daoxi commented Jul 11, 2022

First of all, thanks a lot for adding the new feature for issue #106, but unfortunately it doesn't work properly for certain lyrics modes, take that previously mentioned song for example, when "填充原文" is selected:

It works fine with "优先原/译文（交错）" lyrics mode, but when "仅显示译文" lyrics mode is selected, the untranslated original lyrics don't show/fill up in the translated lyrics (so it's still missing lyrics content).

I personally only uses "仅显示原/译文" lyrics mode, but I also tested the other lyrics modes' behavior with "填充原文", such as "优先原/译文（独立）" and "优先原/译文（合并）" and found they also don't work as intended (try that previously mentioned song for example, and you will see what's wrong).

Version tested: v4.6

daoxi added the bug label

Owner

jitwxs commented Jul 16, 2022

thank you for your feedback, this feature's implements indeed exist something bugs, i will fix it.

jitwxs added a commit that referenced this issue


          fix translate lyric default rule feature bugs #108

3a0024d

jitwxs mentioned this issue

Release v4.7 #111

Merged

jitwxs closed this as completed

jitwxs self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment