Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra/Duplicate Original Lyric Lines in Translated Lyrics #115

Closed
daoxi opened this issue Jul 28, 2022 · 3 comments
Closed

Extra/Duplicate Original Lyric Lines in Translated Lyrics #115

daoxi opened this issue Jul 28, 2022 · 3 comments
Labels

Comments

@daoxi
Copy link
Contributor

daoxi commented Jul 28, 2022

So, as of now there are 3 options to deal with untranslated lyric lines, when I choose the last option (i.e. "填充原文") and the "仅显示译文" lyrics mode, something strange happens:

For this song for example, there are 3 extra/duplicate original lyric lines in translated lyrics, at [01:12.78], [01:19.02], and [03:18.90] respectively, in these 3 timestamps the translated lyric already exists (although the time is off by 0.01 second ([00:00.01]) for unknown reason) and thus the original lyric shouldn't be used to fill in these 3 timestamps.

This issue also seems to happen in other lyrics mode too. Another test example would be this song, in which there're more extra/duplicate original lyric lines in translated lyrics.

Version tested: v4.8

@daoxi daoxi added the bug label Jul 28, 2022
@daoxi daoxi changed the title Extra/Duplicate Original Lyrics Lines in Translated Lyrics Extra/Duplicate Original Lyric Lines in Translated Lyrics Jul 28, 2022
@jitwxs
Copy link
Owner

jitwxs commented Jul 31, 2022

The reason for the difference in lyric timestamp between the origin and the translated is that the server source file is not match, that's what you're say about [00:00.01].

If the timestamp is difference, the program can't match the original and translation lyrics in pairs. This scenario not easy to deal it.

@daoxi
Copy link
Contributor Author

daoxi commented Aug 1, 2022

The reason for the difference in lyric timestamp between the origin and the translated is that the server source file is not match, that's what you're say about [00:00.01].

If the timestamp is difference, the program can't match the original and translation lyrics in pairs. This scenario not easy to deal it.

I see, something is probably wrong on the server side of the lyrics sources (which is definitely the fault of QQ/NetEase Music).

Would it be possible to solve this issue by trying to match the original and translated lyric timestamps within an user-defined tiny interval (e.g. [00:00.01], or [00:00.02], or [00:00.05], etc.)? That will make the original/translated lyrics matching more tolerant of inaccuracy.

For example, if the interval is [00:00.02], then the original lyric at [00:14.47] will be matched with [00:14.45]/[00:14.46]/[00:14.47]/[00:14.48]/[00:14.49] translated lyric (there's typically (99%) only one match, because the lyrics' timestamps are typically more than [00:00.02] apart).

I understand this isn't a perfect solution, but I can't think of a better way to deal with this issue.

@jitwxs
Copy link
Owner

jitwxs commented Sep 4, 2022

see use guide: https://github.com/jitwxs/163MusicLyrics/wiki/4.x-Guide#424-%E8%AF%91%E6%96%87%E5%8C%B9%E9%85%8D%E7%B2%BE%E5%BA%A6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants