-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Timestamps Where the Lyric Content is Empty #117
Comments
Sounds reasonable, will offer a checkbox/togglable option to switch it on/off |
Thanks a lot, looking forward to the next release. |
try use very old versions, I remember there was no such issue before |
The older versions are missing some of the new features I need though. |
I recently tried downloading lyrics in other ways (e.g. browser script), and found the MusicLyricApp has been omitting/excluding empty timestamps (i.e. timestamps where the lyric content is empty.)
Take this song as an example, there should be empty timestamps at
[00:46.24]
,[02:24.67]
, and[04:03.15]
, but these 3 timestamps are all omitted in the lyrics obtained from MusicLyricApp.These empty timestamps are actually pretty useful:
Not every song has empty timestamps, but they're quite useful when included (explained above). So perhaps consider stop omitting them? (Or better, offer a checkbox/togglable option to switch it on/off?)
Version tested: v4.8
The text was updated successfully, but these errors were encountered: