Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Timestamps Where the Lyric Content is Empty #117

Closed
daoxi opened this issue Jul 28, 2022 · 4 comments
Closed

Missing Timestamps Where the Lyric Content is Empty #117

daoxi opened this issue Jul 28, 2022 · 4 comments
Labels

Comments

@daoxi
Copy link
Contributor

daoxi commented Jul 28, 2022

I recently tried downloading lyrics in other ways (e.g. browser script), and found the MusicLyricApp has been omitting/excluding empty timestamps (i.e. timestamps where the lyric content is empty.)

Take this song as an example, there should be empty timestamps at [00:46.24], [02:24.67], and [04:03.15], but these 3 timestamps are all omitted in the lyrics obtained from MusicLyricApp.

These empty timestamps are actually pretty useful:

  1. They tell the users when the lyric from the previous/last timestamp should end (and thus in the music player, the lyric is no longer highlighted once the vocal ends)
  2. They divide the entire lyrics into smaller parts and thus improve organization, they also make the non-vocal parts visible in the lyrics.

Not every song has empty timestamps, but they're quite useful when included (explained above). So perhaps consider stop omitting them? (Or better, offer a checkbox/togglable option to switch it on/off?)

Version tested: v4.8

@daoxi daoxi added the bug label Jul 28, 2022
@jitwxs
Copy link
Owner

jitwxs commented Jul 31, 2022

Sounds reasonable, will offer a checkbox/togglable option to switch it on/off

@daoxi
Copy link
Contributor Author

daoxi commented Aug 1, 2022

Sounds reasonable, will offer a checkbox/togglable option to switch it on/off

Thanks a lot, looking forward to the next release.

@byf3332
Copy link

byf3332 commented Aug 12, 2022

try use very old versions, I remember there was no such issue before

@daoxi
Copy link
Contributor Author

daoxi commented Aug 13, 2022

try use very old versions, I remember there was no such issue before

The older versions are missing some of the new features I need though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants