Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container still running if icinga2 fails. #72

Closed
bebehei opened this issue Jan 18, 2017 · 4 comments
Closed

container still running if icinga2 fails. #72

bebehei opened this issue Jan 18, 2017 · 4 comments

Comments

@bebehei
Copy link
Contributor

bebehei commented Jan 18, 2017

To get #67 merged, I'll record all non-showstoppers by adding new issues.

If the startup of icinga2 fails (configuration fail/whatever), the container will still run, although icinga2 does not do anything. This is a full antipattern against docker's understanding of containers.

To instantly fix this, I would have to get better knowledge of supervisord.

@jjethwa
Copy link
Owner

jjethwa commented Jan 18, 2017

@bebehei

The only downside to this is that there will be no way for a user to determine what caused Icinga2 to fail if the container is stopped automatically and the logs are not being stored in a volume. Maybe if icinga2 startup fails, cat the last X lines from the icinga2 supervisor stdout log file to docker stdout?

@bebehei
Copy link
Contributor Author

bebehei commented Jan 18, 2017

Yes. My favorite solution I wanted, was just piping the whole stdout/err via supervisord out. But I haven't found one.

@bebehei
Copy link
Contributor Author

bebehei commented Jan 19, 2017

The only downside to this is that there will be no way for a user to determine what caused Icinga2 to fail if the container is stopped automatically and the logs are not being stored in a volume. Maybe if icinga2 startup fails, cat the last X lines from the icinga2 supervisor stdout log file to docker stdout?

Fixed this by piping output from supervisor-scripts via supervisor to console, which is managed by docker (run|logs|...). See #74

@bebehei
Copy link
Contributor Author

bebehei commented Feb 2, 2017

I believe after merging #74 this can be closed, too.

@bebehei bebehei closed this as completed Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants