Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct signal-handler for supervisord #74

Merged
merged 5 commits into from
Feb 1, 2017

Conversation

bebehei
Copy link
Contributor

@bebehei bebehei commented Jan 18, 2017

fixes #73

@bebehei
Copy link
Contributor Author

bebehei commented Jan 18, 2017

After a long odyssey, I finally had been able to trace the signals sent. Although supervisord is the active child of bash, it did not get the signals.

Forgot to mention: This introduces behavior, to fail if one service is killed. fixes #72

@@ -14,15 +14,24 @@ supervisor.rpcinterface_factory = supervisor.rpcinterface:make_main_rpcinterface
[supervisorctl]
serverurl=unix:///var/run/supervisor.sock

[eventlistener:eventlistener]
command=/opt/supervisor/eventlistener
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Use a better name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bebehei
Copy link
Contributor Author

bebehei commented Jan 18, 2017

I will add logfile-settings here, later on. Currently testing it

@bebehei bebehei mentioned this pull request Jan 24, 2017
@jjethwa
Copy link
Owner

jjethwa commented Jan 24, 2017

@bebehei

Looks like this one is ready to go as well? Let me know so I can start testing it out.

@bebehei
Copy link
Contributor Author

bebehei commented Jan 24, 2017

Yeah. Both PRs are ready to get merged.

@jjethwa
Copy link
Owner

jjethwa commented Jan 24, 2017

@bebehei

Testing in progress 😄

@jjethwa jjethwa merged commit ad6543a into jjethwa:master Feb 1, 2017
@jjethwa
Copy link
Owner

jjethwa commented Feb 1, 2017

@bebehei

Testing looks good! Merged 😄

@bebehei
Copy link
Contributor Author

bebehei commented Feb 2, 2017

Thanks for handling the icinga2 2.6.1 version. Got the notif this morning, but till now, I had no time.

What do you think about minor-version-branches, e.g. a branch stable-2-6 for stable changes only covering icinga2.6... ?

@jjethwa
Copy link
Owner

jjethwa commented Feb 2, 2017

np! We can totally do that if you think it would be of interest :)

@bebehei
Copy link
Contributor Author

bebehei commented Feb 2, 2017

Regarding #76 i think this is needed in some way. But let's discuss this in a seperate issue.

@bebehei bebehei deleted the signal-handling branch February 6, 2017 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shutdown-functions not used via docker stop
2 participants