-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use correct signal-handler for supervisord #74
Conversation
After a long odyssey, I finally had been able to trace the signals sent. Although supervisord is the active child of bash, it did not get the signals. Forgot to mention: This introduces behavior, to fail if one service is killed. fixes #72 |
@@ -14,15 +14,24 @@ supervisor.rpcinterface_factory = supervisor.rpcinterface:make_main_rpcinterface | |||
[supervisorctl] | |||
serverurl=unix:///var/run/supervisor.sock | |||
|
|||
[eventlistener:eventlistener] | |||
command=/opt/supervisor/eventlistener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Use a better name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
a9e2b7c
to
0a05425
Compare
0a05425
to
ab6df39
Compare
I will add logfile-settings here, later on. Currently testing it |
c926ea7
to
122a204
Compare
122a204
to
a25e593
Compare
Looks like this one is ready to go as well? Let me know so I can start testing it out. |
Yeah. Both PRs are ready to get merged. |
Testing in progress 😄 |
Testing looks good! Merged 😄 |
Thanks for handling the icinga2 2.6.1 version. Got the notif this morning, but till now, I had no time. What do you think about minor-version-branches, e.g. a branch stable-2-6 for stable changes only covering icinga2.6... ? |
np! We can totally do that if you think it would be of interest :) |
Regarding #76 i think this is needed in some way. But let's discuss this in a seperate issue. |
fixes #73