fix: Refactor DICOM tag conversion functions and add test cases

src/nbiatoolkit/dicomtags/tags.py

@@ -220,13 +220,3 @@ def getReferencedSeriesUIDS(series_tags_df: pd.DataFrame) -> List[str]:
     UIDS: list[str] = value["data"].to_list()
 
     return UIDS
-
-
-if __name__ == "__main__":
-    from nbiatoolkit import NBIAClient
-
-    test = convert_element_to_int("(0028,0010)")
-
-    print(test)
-
-    print(convert_int_to_element(test))

tests/test_tags.py

@@ -27,6 +27,9 @@ def test_convert_int_to_element():
     result = convert_int_to_element(65535)
     assert result == "(0000,FFFF)", f"Expected (0000,FFFF), but got {result}"
 
+    with pytest.raises(ValueError) as e:
+        convert_element_to_int("(1,1,1)")
+
     print("All test cases passed!")
 
 
@@ -146,3 +149,8 @@ def test_getSeriesModality(RTSTRUCT_Tags):
 
     with pytest.raises(IndexError) as e:
         getSeriesModality(RTSTRUCT_Tags)
+
+
+def test_failsubsetSeriesTags(RTSTRUCT_Series):
+    with pytest.raises(KeyError) as e:
+        subsetSeriesTags(RTSTRUCT_Series, "(0008,0060)")