Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work anymore #3

Open
dancsi opened this issue Dec 25, 2013 · 3 comments
Open

Doesn't work anymore #3

dancsi opened this issue Dec 25, 2013 · 3 comments

Comments

@dancsi
Copy link

dancsi commented Dec 25, 2013

The bookmarklet does not work anymore. It fails with an

Uncaught TypeError: Cannot read property 'entries' of null
@spiralx
Copy link

spiralx commented Dec 23, 2014

I have two issues, neither of which is the one above...

  • the bookmarklet is too long - after converting spaces to %20s Firefox truncates the bookmarklet at 65,536 characters - quite a bit short of the 95,472 characters it needs for the whole thing.

  • even if I copy and paste the code from here into the console, I get

    TypeError: r.payload is null

    and the number 9 printed after that.

@jkeesh
Copy link
Owner

jkeesh commented Dec 23, 2014

thanks for the comments. havent been able to take a look at this / update
it in a while so it seems like it is likely broken now .. especially with
all the changes fb makes. open to pull requests and maybe i can take a look
at it in the future

On Mon, Dec 22, 2014 at 5:23 PM, James Skinner notifications@github.com
wrote:

I have two issues, neither of which is the one above...

  • the bookmarklet is too long - after converting spaces to %20s
    Firefox truncates the bookmarklet at 65,536 characters - quite a bit short

    of the 95,472 characters it needs for the whole thing.

    even if I copy and paste the code from here into the console, I get

    TypeError: r.payload is null

    and the number 9 printed after that.


Reply to this email directly or view it on GitHub
#3 (comment)
.

@spiralx
Copy link

spiralx commented Dec 23, 2014

I've spent time fixing old bookmarklets before, but yours is huge, and would require that I learn the Graph API properly ;) It was nifty though, back before browsers started cracking down on random bits of code injected into the page.

You might want to update your site though, you're #1 and #2 on Google for "Facebook Friends Finder".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants