Fix fetching of greater than pagesize pubs #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jkeirstead,
Thanks for the nice package. I've noticed that fetching of >pagesize publications by
get_publications
seems to be broken (on develop and on master). For example for myself:both give 20 pubs. Proposed fix in attached.
I also suggest increasing
pagesize
since this has no substantial penalty for short publication lists but has a significant penalty for long lists. For example: