Sort filter proxy implementation. #106
Conversation
| @@ -814,7 +835,7 @@ def show_all_columns(delta_view): | |||
| Helper function to reset columns in the delta_model | |||
| :param delta_view: view to reset | |||
| """ | |||
| model = delta_view.model() | |||
| model = delta_view.model().sourceModel() | |||
There was a problem hiding this comment.
When you have a proxy in place, you need to reach "through" the proxy to get to the actual model. An alternative is just to keep a reference to the model around ourselves (e.g. self.delta_model) -- but if that is replaced, we still need to hook into the proxy model for it to work.
When you have an value on an object e.g. self.delta_model and replace it by assigning to it self.delta_model = MyNewModel() that changes the object in self.delta_model but all existing links are still pointing at the old object.
| @@ -237,6 +247,9 @@ def __init__(self, parent): | |||
| layout_main.addWidget(main_vsplitter_window) | |||
| self.setLayout(layout_main) | |||
|
|
|||
| # Call reset to initialize the table models. | |||
| self.reset() | |||
|
|
|||
| def reset(self): | |||
There was a problem hiding this comment.
If you have a reset method like this, it's is usually good to re-use it for the setup during init (to avoid code duplication).
| @@ -246,9 +259,17 @@ def reset(self): | |||
| self.axes_drift_cont_upper.figure.canvas.draw() | |||
| self.axes_drift_cont_lower.figure.canvas.draw() | |||
| self.axes_drift_single.figure.canvas.draw() | |||
| self.delta_view.setModel(DeltaTableModel()) | |||
There was a problem hiding this comment.
These lines changed the model on the view, but do not change what is pointed to e.g. by self.dg_samples_table -- so you now have two models existing at the same time. This might have been throwing the errors due to mismatches between items.
The DeltaTableModel() call doesn't keep a reference to that model, I'm 50:50 on whether that means the Python part would be garbage collected. If that happened you'd see segfaults.
| @@ -224,8 +228,14 @@ def __init__(self, parent): | |||
| self.roman_label_widget.hide() | |||
|
|
|||
| # dg table (Roman method) | |||
| self.dg_samples_view.setModel(self.dg_avg_model) | |||
There was a problem hiding this comment.
I find the names of the views and the models very confusing (they don't really match up in my head)!
This adds QSortFilterProxy sorting proxy models to the drift tab as an example. I chose this as I could see something there that could explain the issues you were experiencing before.
See the comments on the source for details.