Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup fortran files #54

Merged
merged 12 commits into from
May 14, 2019
Merged

Cleanup fortran files #54

merged 12 commits into from
May 14, 2019

Conversation

jklenzing
Copy link
Member

Replace msis file with official release from https://map.nrl.navy.mil as base. Modifications added to independently scale Tinf, as well as make compatible with gfortran.

Removed unused files from hwm.

This still needs a comparison to see if physical output is realistic.

@jklenzing jklenzing added this to the Beta Release milestone Apr 29, 2019
@jklenzing
Copy link
Member Author

Updated setup file with new python versions

@jklenzing
Copy link
Member Author

Updated travis to xenial for all versions to be more future-compatible.

@jklenzing
Copy link
Member Author

Added official version of hwm and general cleanup.

Verified that code runs and generates reasonable output.

Ready for review.

Copy link
Collaborator

@JonathonMSmith JonathonMSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps in the README.md there should be a statement about setting the paths using utils. This looks good though and I think it's ready for a push. If you'd like to make those changes to the filenames I'll look forward to reviewing that.

@jklenzing
Copy link
Member Author

New file uploaded. Had to update the line endings to get diff to run. Mostly changes to comments, but I caught a few new lines of code as well.

I'll update the documentation as part of the documentation branch I'm working on.

@jklenzing
Copy link
Member Author

perhaps in the README.md there should be a statement about setting the paths using utils.

Added this to #57 as part of planned update to user directory.

@jklenzing jklenzing merged commit 150d4d4 into develop May 14, 2019
@jklenzing jklenzing deleted the cleanup branch May 14, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants