Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readding callee check. #634

Merged
merged 12 commits into from
Jun 11, 2018
Merged

Readding callee check. #634

merged 12 commits into from
Jun 11, 2018

Conversation

nyon
Copy link
Contributor

@nyon nyon commented Jun 5, 2018

Hello,

this readds the callee check für partial blocks as discussed here

@codecov-io
Copy link

Codecov Report

Merging #634 into master will decrease coverage by 0.02%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #634      +/-   ##
============================================
- Coverage     87.24%   87.21%   -0.03%     
- Complexity      826      832       +6     
============================================
  Files            78       78              
  Lines          2979     2989      +10     
  Branches        404      407       +3     
============================================
+ Hits           2599     2607       +8     
- Misses          260      261       +1     
- Partials        120      121       +1
Impacted Files Coverage Δ Complexity Δ
...ebars/internal/PartialBlockForwardingTemplate.java 94.44% <100%> (ø) 2 <0> (ø) ⬇️
...com/github/jknack/handlebars/internal/Partial.java 91.59% <80%> (-1.07%) 30 <4> (+6)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced0423...81438e1. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 91.268% when pulling 81438e1 on nyon:master into ced0423 on jknack:master.

@jknack jknack added this to the 4.1.0 milestone Jun 9, 2018
@jknack jknack merged commit af5a7b9 into jknack:master Jun 11, 2018
jknack added a commit that referenced this pull request Jun 11, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants