Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POM of main screen of agama #9

Merged
merged 1 commit into from Aug 18, 2023
Merged

Conversation

Copy link
Collaborator

@rakoenig rakoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@sofiasyria sofiasyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I commented on some needed changes due to the newest Dolomite changes. Green VRs would be nice to have.

tests/full-disk-encryption.spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@sofiasyria sofiasyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pages/main-page.ts Show resolved Hide resolved
pages/main-page.ts Outdated Show resolved Hide resolved
pages/main-page.ts Outdated Show resolved Hide resolved
pages/main-page.ts Outdated Show resolved Hide resolved
pages/main-page.ts Outdated Show resolved Hide resolved
@lemon-suse lemon-suse force-pushed the add-pom-main-page branch 7 times, most recently from 72a7de1 to d6bd406 Compare August 17, 2023 04:09
@sofiasyria sofiasyria mentioned this pull request Aug 17, 2023
@jknphy jknphy merged commit 652d9ba into jknphy:main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants