Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hard coded product names in playwright test specs #17524

Merged

Conversation

lemon-suse
Copy link
Contributor

@lemon-suse lemon-suse commented Aug 3, 2023

Change hard coded product names in playwright test specs, add upload trace file for tests/yam/agama/agama_full_disk_encryption.pm.

@lemon-suse lemon-suse added qe-yam urgent The ticket that cuase this PR was urgent. labels Aug 3, 2023
@sofiasyria
Copy link
Contributor

sofiasyria commented Aug 4, 2023

I am getting confused. We have three tests: lvm, full_disk_encryption and take_screenshots. For each, we have a different module that is very similar but has some differences like the base (why we have agama_base in some and y2_installbase in other?) and the test name. We could use the same base for all and have the post_fail_hook there. And we could also use the same module for all tests and just change the test name, same as you did for the product name. I'd suggest for now to just skip adding the post_fail_hook. Merge your code and open a follow up ticket to tidy this mess up. WDYT?

@lemon-suse
Copy link
Contributor Author

I am getting confused. We have three tests: lvm, full_disk_encryption and take_screenshots. For each, we have a different module that is very similar but has some differences like the base (why we have agama_base in some and y2_installbase in other?) and the test name. We could use the same base for all and have the post_fail_hook there. And we could also use the same module for all tests and just change the test name, same as you did for the product name. I'd suggest for now to just skip adding the post_fail_hook. Merge your code and open a follow up ticket to tidy this mess up. WDYT?

Aha, we already have the ticket, https://progress.opensuse.org/issues/132989

@lemon-suse
Copy link
Contributor Author

I am getting confused. We have three tests: lvm, full_disk_encryption and take_screenshots. For each, we have a different module that is very similar but has some differences like the base (why we have agama_base in some and y2_installbase in other?) and the test name. We could use the same base for all and have the post_fail_hook there. And we could also use the same module for all tests and just change the test name, same as you did for the product name. I'd suggest for now to just skip adding the post_fail_hook. Merge your code and open a follow up ticket to tidy this mess up. WDYT?

Aha, we already have the ticket, https://progress.opensuse.org/issues/132989

Removed the post_fail_hook.

@sofiasyria sofiasyria merged commit 9fe578f into os-autoinst:master Aug 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qe-yam urgent The ticket that cuase this PR was urgent.
Projects
None yet
3 participants