Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TabError in detect_cycle_test #38

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Conversation

h4iku
Copy link
Contributor

@h4iku h4iku commented Apr 3, 2022

Fixes the inconsistent use of tabs and spaces that doesn't let the test run.

@drrckln drrckln self-assigned this Apr 3, 2022
@drrckln
Copy link
Collaborator

drrckln commented Apr 3, 2022

Thanks! Given the clarity of the issue I expect to merge this soon. I'm a bit surprised this hasn't come up before; can you tell me the conditions under which this error occurred?

@drrckln
Copy link
Collaborator

drrckln commented Apr 3, 2022

Ah, I'm noting this section was added in the most recent merged PR.

@drrckln drrckln merged commit 6ee7474 into jkoppel:master Apr 3, 2022
@h4iku
Copy link
Contributor Author

h4iku commented Apr 3, 2022

Yeah, I just ran the tester script for detect_cycle and under Bad Python: it gave TabError.

@drrckln
Copy link
Collaborator

drrckln commented Apr 3, 2022

Appreciated. Thanks again; let us know if anything else pops up (particularly with the Java detect cycle test).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants