Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build on macOS #19

Closed
certik opened this issue Nov 18, 2019 · 2 comments
Closed

Fails to build on macOS #19

certik opened this issue Nov 18, 2019 · 2 comments

Comments

@certik
Copy link
Contributor

certik commented Nov 18, 2019

I tried both gcc 9.1.0 and the default clang on macOS 10.11.6 and I got the same failure:

In file included from /Users/ondrej/repos/JKQtPlotter/lib/jkqtcommon/jkqtplinalgtools.h:39,
                 from /Users/ondrej/repos/JKQtPlotter/lib/jkqtcommon/jkqtplinalgtools.cpp:22:
/Users/ondrej/repos/JKQtPlotter/lib/./jkqtcommon/jkqtparraytools.h: In function ‘void* jkqtpArrayMalloc(size_t)’:
/Users/ondrej/repos/JKQtPlotter/lib/./jkqtcommon/jkqtparraytools.h:81:12: error: ‘_aligned_malloc’ was not declared in this scope
   81 |     return _aligned_malloc(size, JKQTP_ALIGNMENT_BYTES);
      |            ^~~~~~~~~~~~~~~
/Users/ondrej/repos/JKQtPlotter/lib/./jkqtcommon/jkqtparraytools.h: In function ‘void jkqtpArrayFree(void*)’:
/Users/ondrej/repos/JKQtPlotter/lib/./jkqtcommon/jkqtparraytools.h:122:9: error: ‘_aligned_free’ was not declared in this scope
  122 |         _aligned_free(data);
      |         ^~~~~~~~~~~~~
make[2]: *** [lib/jkqtcommon/CMakeFiles/JKQTCommonSharedLib.dir/jkqtplinalgtools.cpp.o] Error 1
make[1]: *** [lib/jkqtcommon/CMakeFiles/JKQTCommonSharedLib.dir/all] Error 2
make: *** [all] Error 2
jkriege2 added a commit that referenced this issue Nov 18, 2019
…tpArrayFree() (which were a remenant of QuickFit 3 and not really portable or useful)
@jkriege2
Copy link
Owner

Should be fixed with my last commit ... these are remenants of an older project and not really needed any more ... and (as you found out) not very portable without the appropriate compiler defines

@certik
Copy link
Contributor Author

certik commented Nov 18, 2019

I tested it and it works on macOS for me now. Thank you!

(There are still a lot of warnings, but that's a relatively minor issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants