Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS Support #81

Closed
sufuk opened this issue Jul 15, 2022 · 9 comments
Closed

IOS Support #81

sufuk opened this issue Jul 15, 2022 · 9 comments

Comments

@sufuk
Copy link

sufuk commented Jul 15, 2022

I am trying to build JKQTLPOTTER for iOS but I am stuck with PrintSupport it seems Qt IOS SDK doesnt include QtPrintSupport is it possible use JKQTPLOTTER without PrintSupport ?

@jkriege2
Copy link
Owner

Hi!

Right now it is not possible, but QPrintSupport is not essential and it would be possible to exclude it and all functionaliry that use it (I.e. the print() function, QActions that bind to it, the print preview etc.

Easiest would be to define a default-on option in CMake and QMake that is used to (un)define a #define, which is subsequently used to switch off that code.

Would you be willing to contribute such a PR?

Also: if you find additional changes necessary, I would be happy to merge these into the codename. Best as a separate PR un order to

@jkriege2
Copy link
Owner

Separate topics

Best,
Jan

@sufuk
Copy link
Author

sufuk commented Jul 17, 2022

Hello,
I started to implement a version works without QPrintSupport I will be in touch shortly.

Regards...
Semih Ufuk Güler

@sufuk
Copy link
Author

sufuk commented Jul 17, 2022

Its done, but controls is behaving weirdly probably because of ios simulator I cannot test on a real device because I dont own an apple phone, PR comming shorlty

image

jkriege2 added a commit that referenced this issue Jul 18, 2022
…it can be switched off with the CMake-option JKQtPlotter_BUILD_FORCE_NO_PRINTER_SUPPORT=ON
@jkriege2
Copy link
Owner

Please check out my latest commit. Does it do what you need? You can disable print-support using the CMake option JKQtPlotter_BUILD_FORCE_NO_PRINTER_SUPPORT=ON

@sufuk
Copy link
Author

sufuk commented Jul 19, 2022

CMake Error at lib/jkqtmathtext/CMakeLists.txt:132 (JKQtMathText_setDefaultLibOptions):
JKQtMathText_setDefaultLibOptions Function invoked with incorrect arguments
for function named: JKQtMathText_setDefaultLibOptions

I started to get this error

@jkriege2
Copy link
Owner

should be fixed

@sufuk
Copy link
Author

sufuk commented Jul 19, 2022

should be fixed

Yeah thank you it is fixed.
Congrats now JKQTPLOTTER can be used with iOS !!!!

@jkriege2
Copy link
Owner

can be closed?

@sufuk sufuk closed this as completed Jul 20, 2022
hgpark3dii pushed a commit to hgpark3dii/JKQtPlotter that referenced this issue May 25, 2023
…ddition it can be switched off with the CMake-option JKQtPlotter_BUILD_FORCE_NO_PRINTER_SUPPORT=ON
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants