Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Next 13 #24

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Upgrade to Next 13 #24

merged 4 commits into from
Sep 6, 2023

Conversation

soupaJ
Copy link
Collaborator

@soupaJ soupaJ commented Sep 4, 2023

Upgrading to Next 13 to take advantage of some of the latest features like app router. This PR does not attempt to migrate to the app router just yet.

@vercel
Copy link

vercel bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gistdoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 0:40am

@soupaJ soupaJ changed the title Upgrade to Next 13 WIP: Upgrade to Next 13 Sep 5, 2023
@soupaJ soupaJ marked this pull request as ready for review September 5, 2023 00:42
@soupaJ soupaJ changed the title WIP: Upgrade to Next 13 Upgrade to Next 13 Sep 5, 2023
@soupaJ soupaJ requested a review from jkulton September 5, 2023 00:42
@soupaJ
Copy link
Collaborator Author

soupaJ commented Sep 5, 2023

@jkulton The minimum node version was bumped to node v16 for Next.js 13 so I had to bump the versions in the github workflow.

https://nextjs.org/docs/pages/building-your-application/upgrading/version-13#v13-summary

@jkulton
Copy link
Owner

jkulton commented Sep 6, 2023

@soupaJ I also tried to update the project on the Vercel side (and think I did successfully) as it gave me a warning about being on an old version of Node.

I'll test out your changes later this week and see about getting this deployed. 👍

@jkulton
Copy link
Owner

jkulton commented Sep 6, 2023

☑️ Upgraded Vercel project to Node v18
☑️ Code looks good
☑️ Staging deployment looks good

🚀 🚀 🚀

I'm going to bypass the check since it's looking for the v14 check that no longer exists.

@jkulton jkulton merged commit 2b6df0b into jkulton:main Sep 6, 2023
4 checks passed
@jkulton
Copy link
Owner

jkulton commented Sep 6, 2023

New version is live, thanks @soupaJ!

I also updated the changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants