Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in package.json specify "main" as ng2-uploader.js #111

Merged
merged 2 commits into from
Oct 13, 2016

Conversation

karlhiramoto
Copy link
Contributor

I think (not 100% sure) as per the typescript publishing docs The main should be the compiled .js file

I've run into this issue on a SystemJS project. steps to reproduce:

  1. clone https://github.com/mgechev/angular-seed
  2. cd angular-seed
  3. npm install ng2-uploader --save

Follow your readme instructions.

Other projects in typescript define "main" as a js file for example:

@jkuri
Copy link
Contributor

jkuri commented Oct 13, 2016

@karlhiramoto thanks for your PR. Yes, this is needed for SystemJS to find the .js file but in with webpack and rollup you then need to include it as import { UPLOAD_DIRECTIVES } from 'ng2-uploader/ng2-uploader';. Can you make changes to README with that note please?

@karlhiramoto
Copy link
Contributor Author

OK updated README.

If you can pull this, please also update the npm package.

Thanks.

@jkuri jkuri merged commit c0eacb5 into bleenco:master Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants