Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bindgen signedness on Windows #16

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Conversation

waych
Copy link
Contributor

@waych waych commented Jul 12, 2021

When building on x64_64-pc-windows-msvc, the types for enums are by
default signed, resulting in many errors of the flavor:

expected `u32`, found `i32`

for types all enum value assignments that map enum types to those
exposed by russimp-sys.

When building on x64_64-pc-windows-msvc, the types for enums are by
default signed, resulting in many errors of the flavor:

    expected `u32`, found `i32`

for types all enum value assignments that map enum types to those
exposed by `russimp-sys`.
@jkvargas
Copy link
Owner

jkvargas commented Jul 12, 2021

hey mate, thanks so much for your contribution.
Would you mind to raise the cargo.toml version please?
0.2.3 would be fine.

Also, I am looking for someone to add a windows building to our yml.
In case you interested haha =)

@jkvargas jkvargas merged commit ae45635 into jkvargas:master Jul 12, 2021
@waych
Copy link
Contributor Author

waych commented Jul 12, 2021

FYI I got cargo test --lib building and passing on Windows locally. I should be able to send you a workflow config, but to make it work requires the following:

  • a fix to the upstream vcpkg assimp port, as it seems to be linking two copies (incompatible?) of polyclipping
  • small fix to russimp-sys to also link windows system libs (pulled in indirectly via irrlicht).

@jkvargas
Copy link
Owner

Sounds great bud.
I made a small request on your other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants