Updated the Request object to enable type capture on the attribute(St…

…ring) method.
jkwatson · Jul 19, 2014 · eec4896 · eec4896
1 parent 1ecd428
commit eec4896
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/spark/Request.java b/src/main/java/spark/Request.java
@@ -301,8 +301,8 @@ public void attribute(String attribute, Object value) {
      * @param attribute The attribute value or null if not present
      * @return the value for the provided attribute
      */
-    public Object attribute(String attribute) {
-        return servletRequest.getAttribute(attribute);
+    public <T> T attribute(String attribute) {
+        return (T) servletRequest.getAttribute(attribute);
     }
 
 

diff --git a/src/main/java/spark/webserver/RequestWrapper.java b/src/main/java/spark/webserver/RequestWrapper.java
@@ -178,7 +178,7 @@ public void attribute(String attribute, Object value) {
     }
 
     @Override
-    public Object attribute(String attribute) {
+    public <T> T attribute(String attribute) {
         return delegate.attribute(attribute);
     }
 

diff --git a/src/test/java/spark/examples/filter/FilterExampleAttributes.java b/src/test/java/spark/examples/filter/FilterExampleAttributes.java
@@ -44,12 +44,12 @@ public static void main(String[] args) {
         });
 
         after("/hi", (request, response) -> {
-            Object foo = request.attribute("foo");
+            String foo = request.attribute("foo");
             response.body(asXml("foo", foo));
         });
     }
 
-    private static String asXml(String name, Object value) {
+    private static String asXml(String name, String value) {
         return "<?xml version=\"1.0\" encoding=\"UTF-8\"?><" + name + ">" + value + "</" + name + ">";
     }