fixed div attributes in split_stats().get_player_info() #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
div attributes for the bio section have changed which resulted in searches not finding any content. updated the attribute parameters and it is now working.
|
Hey @TobiasCortese, appreciate you making this PR and finding this issue! It looks like the fix was incorporated in #318 so it seems to be working well on master now. Ok if I close this? |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
div attributes for the bio section in the split_stats() code get_player_info() method have changed which resulted in searches not finding any content. updated the attribute parameters and it is now working.