Onydra/hash param view mode #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @onydra! Thanks for the contribution! This seems fine to me in principle, but I'd prefer to have the view mode have a string name rather than an integer. Right now, if the enum was reordered, this would change functionality, which I wouldn't expect. What do you think about You'll also need to revert the change to |
|
I'm going to close this out for inactivity. Feel free to open if you'd like to see this landed once the requested changes have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jlfwong, thanks for this wonderful tool. This PR simply adds the ability to set the default viewMode from hash params so that one can directly link the most relevant view.