add default instruments selected run number

[Archerlly]

this's will lack com.apple.xray.owner.template in instruments archive data where run instruments with command line.
like:

1. runinstruments -t Template.tracetemplate -D demo.trace -l 10000 -w test.app
2. drag demo.trace into https://www.speedscope.app
3. alert Unrecognized format! See documentation about supported formats

[coveralls]

Coverage increased (+0.2%) to 46.817% when pulling f73fed1 on Archerlly:master into ddc6130 on jlfwong:master.

[jlfwong]

Hi @Archerlly,

Thanks for the submission!

Do you have a small .trace file that you can include as a test to ensure that this behavior doesn't regress in the future?

I should be able to create this myself, though I'm not sure where to find a .tracetemplate file to create this.

[jlfwong]

I don't think this is quite right. The in test is for objects, not arrays, and Object.keys returns an array, so I think this condition will always be false.

Instead, I think you want:

Suggested change

	if ('com.apple.xray.owner.template' in Object.keys(archive)) {
	if ('com.apple.xray.owner.template' in archive) {

[jlfwong]

I'm guessing this was useful for debugging, but can you please remove this before we merge?

[Archerlly]

• .tracetemplate file create by Instruments File -> Save As Template
• console.log('get selectedRunNumber', selectedRunNumber) is debug code and have removed
• add a testing with small .trace file that without selected run number

Thanks for your suggestion

[Archerlly]

• remove * console.log('get selectedRunNumber', selectedRunNumber)
• remove Object.keys for in func
• add a testing with small .trace file that without selected run number

Thanks for your suggestion

[jlfwong]

@Archerlly Your fix has now been published to npm and deployed to https://speedscope.app/. Thanks for the fix!