New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accidentally added/retained dependencies on react and react-redux #315

Merged

jlfwong merged 2 commits into master from jlfwong/rm-react

Sep 29, 2020

Owner

jlfwong commented Sep 29, 2020 •

edited

Loading

speedscope no longer relies upon react-redux, and never depended upon react. Let's clean these up.

jlfwong added 2 commits

September 29, 2020 15:49


          Remove react from dependencies

86f3a1a


          Remove accidentally dependencies on react and react-redux

9312db0

coveralls commented Sep 29, 2020

Coverage remained the same at 47.178% when pulling 9312db0 on jlfwong/rm-react into f758130 on master.

jlfwong merged commit ede9c74 into master

jlfwong deleted the jlfwong/rm-react branch

September 29, 2020 23:20

jackerghan pushed a commit to jackerghan/speedscope that referenced this pull request


          Remove accidentally added/retained dependencies on react and react-re…

c8a97d9

…dux (jlfwong#315)

speedscope no longer relies upon react-redux, and never depended upon react. Let's clean these up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment