Skip to content

Commit

Permalink
Remove accidentally dependencies on react and react-redux
Browse files Browse the repository at this point in the history
  • Loading branch information
jlfwong committed Sep 29, 2020
1 parent 86f3a1a commit 9312db0
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 68 deletions.
73 changes: 7 additions & 66 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
"preact": "10.4.1",
"prettier": "2.0.4",
"protobufjs": "6.8.8",
"react-redux": "^7.2.0",
"redux": "^4.0.5",
"ts-jest": "24.3.0",
"typescript": "3.9.2",
Expand Down
2 changes: 1 addition & 1 deletion src/lib/preact-redux.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* As of Preact 10.x, they no longer have an officially supported preact-redux library.
* It's possible to use react-redux with some hacks, but these hacks cause npm run pack
* to error out because of (intentinoally) unmet peer dependencies.
* to error out because of (intentionally) unmet peer dependencies.
*
* I could stack more hacks to fix this problem, but I'd rather just drop the dependency
* and remove the need to do any dependency hacking by writing the very small part of
Expand Down

0 comments on commit 9312db0

Please sign in to comment.