Fixed FORWARD_WORD to actually match readline behavior #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
added a commit
that referenced
this pull request
Jan 20, 2012
Fixed FORWARD_WORD to actually match readline behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of FORWARD_WORD does not actually match readline behavior. It incorrectly moves one separator past the end of the word. To illustrate (using | to show the cursor):
Current behavior:
Readline behavior:
The current problem is because the logic in nextWord() is implementing by looking at the character before the cursor instead of the character after cursor. This pull request fixes this problem and results in matching the behavior of readline.