Updating CONTRIBUTING

CONTRIBUTING.md

@@ -1,2 +1,40 @@
-Please see my contributing rules outlined here: http://mooash.github.io/contributing/
+### General
 
+I've set some general contribution outlines [here](https://mooash.github.io/contributing/#pk_campaign=GitHub-Project&pk_kwd=nagios-nrpe-server). Please read them before opening a pull request.
+
+### Project Specific
+
+#### Ansible formatting
+
+I try and follow Ansible's [playbook best practices](https://docs.ansible.com/playbooks_best_practices.html) to the best of my ability. That said, these rules always apply:
+
+ * [Always Mention The State](https://docs.ansible.com/playbooks_best_practices.html#always-mention-the-state)
+ * Move big plays to multiple lines. Plays like template look ugly on single lines.  
+   Not OK:
+
+   ```yaml
+   # Create nrpe_ansible.cfg
+    - name: Create nrpe_ansible.cfg from template
+      sudo: true
+      template: src="nrpe_ansible.cfg.j2" dest="{{ nagios_nrpe_server_dir }}/nrpe_ansible.cfg" owner=root group=root mode=0644
+      notify: restart nagios-nrpe-server
+    ```
+
+    OK:
+
+    ```yaml
+    # Create nrpe_ansible.cfg
+    - name: Create nrpe_ansible.cfg from template
+      sudo: true
+      template: >
+        src="nrpe_ansible.cfg.j2"
+        dest="{{ nagios_nrpe_server_dir }}/nrpe_ansible.cfg"
+        owner=root group=root mode=0644
+      notify: restart nagios-nrpe-server
+    ```
+ * If a play is OS specific, state it in the play name.  
+   eg: `- name: Installing packages [Debian]` or `- name: Installing packages [RedHat]`
+
+### Questions?
+
+If you're confused on any of the above, just contact me so I can clear up my documentation.

LICENSE

@@ -19,4 +19,3 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
-

README.md

@@ -68,4 +68,3 @@ Author Information
 ------------------
 
 Checkout my blog [here](http://www.mooash.me)
-

defaults/main.yml

@@ -2,4 +2,3 @@
 nagios_nrpe_server_bind_address: 127.0.0.1
 nagios_nrpe_server_port: 5666
 nagios_nrpe_server_allowed_hosts: 127.0.0.1
-

handlers/main.yml

@@ -6,4 +6,3 @@
 - name: restart nagios-nrpe-server
   sudo: true
   service: name="{{ nagios_nrpe_server_service }}" state=restarted
-

meta/main.yml

@@ -21,4 +21,3 @@ galaxy_info:
     - monitoring
     - system
 dependencies: []
-

tasks/main.yml

@@ -59,4 +59,3 @@
 - name: Ensure NRPE server is running
   sudo: true
   service: name="{{ nagios_nrpe_server_service }}" state=started enabled=yes
-

tasks/packages-archlinux.yml

@@ -8,4 +8,3 @@
 - name: Install Nagios NRPE Server [Arch Linux]
   sudo: true
   pacman: name=nrpe state=present
-

tasks/packages-debian.yml

@@ -8,4 +8,3 @@
 - name: Install Nagios NRPE Server [Debian]
   sudo: true
   apt: name=nagios-nrpe-server state=present
-

tasks/packages-redhat.yml

@@ -10,4 +10,3 @@
   sudo: true
   yum: name=nagios-plugins-all state=present enablerepo="{{ nagios_nrpe_server_repo_redhat }}"
   notify: restart nagios-nrpe-server
-

templates/nrpe.cfg.j2

@@ -213,4 +213,3 @@ include={{ nagios_nrpe_server_dir }}/nrpe_ansible.cfg
 # only snipplets ending in .cfg will get included
 include_dir={{ nagios_nrpe_server_dir }}/nrpe.d/
 {% endif %}
-

templates/nrpe_ansible.cfg.j2

@@ -5,4 +5,3 @@
 
 # Example check
 command[check_mailq]={{ nagios_nrpe_server_plugins_dir }}/check_mailq -c 50 -w 20
-

vars/Archlinux.yml

@@ -7,4 +7,3 @@ nagios_nrpe_server_group: 31
 nagios_nrpe_server_service: nrpe
 nagios_nrpe_server_plugins_dir: /usr/lib/monitoring-plugins
 nagios_nrpe_server_dir: /etc/nrpe
-

vars/Debian.yml

@@ -9,4 +9,3 @@ nagios_nrpe_server_group: nagios
 nagios_nrpe_server_service: nagios-nrpe-server
 nagios_nrpe_server_plugins_dir: /usr/lib/nagios/plugins
 nagios_nrpe_server_dir: /etc/nagios
-

vars/RedHat-x64.yml

@@ -1,2 +1 @@
 nagios_nrpe_server_plugins_dir: /usr/lib64/nagios/plugins
-

vars/RedHat-x86.yml

@@ -1,2 +1 @@
 nagios_nrpe_server_plugins_dir: /usr/lib/nagios/plugins
-

vars/RedHat.yml

@@ -9,4 +9,3 @@ nagios_nrpe_server_group: nrpe
 nagios_nrpe_server_repo_redhat: epel
 nagios_nrpe_server_service: nrpe
 nagios_nrpe_server_dir: /etc/nagios
-