Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Path must be a string. Received undefined #29

Open
benbalter opened this issue May 29, 2016 · 3 comments
Open

TypeError: Path must be a string. Received undefined #29

benbalter opened this issue May 29, 2016 · 3 comments
Labels

Comments

@benbalter
Copy link

👋 @jlord! Big net promoter of offline-issues. It seems I recently started receiving the following error:

$ offline-issues benbalter/benbalter.github.com
Wrote data.
Wrote markdown files.
Wrote html files.
path.js:7
    throw new TypeError('Path must be a string. Received ' + inspect(path));
    ^

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.dirname (path.js:1324:5)
    at copy (/usr/local/lib/node_modules/offline-issues/node_modules/cpr/lib/index.js:136:28)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

This appeared immediately after logging in with 2FA and attempting to clone down the issues for my public, personal site (benbalter/benbalter.github.com).

I swear I read the directions (and things had been working great for a while). Using v0.1.0.

This occurs if I use the global offline-issues bin, or if I invoke ./node_modules/.bin/offline-issues directly from my project. Halp?

@jlord
Copy link
Owner

jlord commented Jun 3, 2016

Hmm, ok I just cloned the project fresh on a newish computer and npm linked it and ran it on a couple of repositories (including benbalter/benbalter.github.com) and it worked. I'll dig around some more and try and see what's up.

@jlord jlord mentioned this issue Jun 3, 2016
@jlord
Copy link
Owner

jlord commented Jun 3, 2016

I ended up getting this error when I was testing the module on Ubuntu. I tracked it down to being because cpr didn't know to overwrite files that were duplicates when offline-issues was run twice in the same dir.

@benbalter if you could update your dependency or clone and install master and then npm link and let me know if things are better now?

Or after today I'll publish a new version to npm and you can just wait for that.

@jlord jlord added the bug label Jun 3, 2016
@benbalter
Copy link
Author

was run twice in the same dir.

Ahh, that sounds like my problem. Not urgent. Will wait for the NPM fix. Thanks for looking into this! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants