Handle coercion of default values #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the dungeon such that every enumeration is an atom internally. Observe that parameter-passed values do not enjoy being fed through the enumeration module resolver. This is obviously a problem which needs some addressing. In this patch, we currently detect the problem, but we don't provide a fix yet.
|
I now understand the bug: In this case, we have a default mood, and it is represented as |
jlouis
changed the title
Closed
This plugs a hole in the coercion code with enumerated types. If an
enum is supplied as a default it was never coerced, but because the
default value was {enum, X} and the default coercer returned {enum, X}
nobody ever saw this.
Default values are now param-checked like everything else. If they
fail, the output error is different and we drop an error in the error
logger because this is a misconfiguration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the dungeon such that every enumeration is an atom internally.
Observe that parameter-passed values do not enjoy being fed through
the enumeration module resolver. This is obviously a problem which
needs some addressing. In this patch, we currently detect the problem,
but we don't provide a fix yet.