-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fails in Remove large packages #8
Conversation
Allow fails in Remove large packages
Thank you very much @kfir4444 for suggesting this improvement! I wanted to ask your opinion:
Also, do you know which packages you have had an issue with? My impression is that this can be merged without any impact to existing users, but I would like to double check you believe so too. Thank you! |
Thanks for the replay @jlumbroso! 😃 |
Solution of @kfir4444 looks good can we approve this PR please many user facing issues |
Thanks @pratik-techholding! |
Maybe this could fix #9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 LGTM! Thank you for this change!
I'd be happy if this PR is merged as-is to simply unblock about a dozen or so of my repos' CI runs. The suggestion simply addresses @jlumbroso's question in their comment here; IMO, having messages printed for these command failures a 'nice-to-have', but not required. I'd rather see my CI jobs unblocked sooner rather than later.
@jlumbroso - by allowing this PR to be merged in and released, the below issues / PRs would be closed / addressed:
Thoughts on getting this merged in to unblock the many CI runs that are affected by issues this PR addresses?
Hi, when do we expect to get the fix merged in? This issue is breaking my CI too |
Hi @jlumbroso - do you have any subsequent concerns and/or blockers to getting this PR merged? If you need extra help maintaining this repository, I'd be happy to volunteer to assist (I have experience with authoring & maintaining several GHAs); just let me know. |
@jlumbroso as @ChrisCarini, I can also help with maintenance 😄 |
For everyone else struggling with issues, you can use my fork for now (this is what we do in our repos) until this chage becomes official. I can tag you here when this PR is merged so you can return to the original. |
Don't you get for free the error check if you support "continue-on-error: true" in the action? |
This would also fix #4. I assume @jlumbroso has just not had a chance to look at this. |
Co-authored-by: Chris Carini <6374067+ChrisCarini@users.noreply.github.com>
Sorry for the delay. @ChrisCarini Thank you for addressing my concerns with your change. |
No worries!
Of course! FWIW, my offer to help you maintain this repo (ref: #8 (comment) ) (approving/merging PRs, releasing new versions, etc) still stands. :) Just let me know! Happy to help. |
…rification workflow." This reverts commit a52886d. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0).
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#282) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#188) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#184) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#247) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#158) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#204) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#231) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#134) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#193) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#228) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#250) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
…rification workflow."; Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0; Do not delete docker images from JetBrains compatibility GitHub Workflow. (#196) * Revert "Use temporary GHA to clear more diskspace for IDE platform verification workflow." This reverts commit a52886de94228e8250b852ba1c8075a35a4681bd. Reverting because jlumbroso/free-disk-space#8 is now resolved and released (v1.3.0). * Bump jlumbroso/free-disk-space from 1.2.0 to 1.3.0 * Do not delete docker images from JetBrains compatibility GitHub Workflow.
Added
|| true
at the end of large file removal, so that if one step of it fails, the clean-up job would continue.