Allow fails in Remove large packages

[kfir4444]

Added || true at the end of large file removal, so that if one step of it fails, the clean-up job would continue.

[jlumbroso]

Thank you very much @kfir4444 for suggesting this improvement!

I wanted to ask your opinion:

• Do you think there are any scenarios where the user may want this to fail? (Should this be a flag.)
• Do you think that it would be useful to print something when the command fails, or do you think the log output produced by the commands is sufficient?

Also, do you know which packages you have had an issue with?

My impression is that this can be merged without any impact to existing users, but I would like to double check you believe so too. Thank you!

[kfir4444]

Thanks for the replay @jlumbroso! 😃
Regarding your first question, I can think of some scenarios where this action could be used as a test, so a failure here could be important, but I think that the general use case only benefits from not stopping a CI due to failed deletion, which hinders development.
Well, we use this github action in (at least) one of our repos and got some CI fails (example here) due to a false return code in ubuntu. I think that the users can tolerate a difference of a few mb's extra, but have a CI fail a few times due to uninstallation error may discourage users to use this tool. Also, I recall talking to a colleague and postulating that this issue may had something to do with the new ubuntu release and additional packages still being adapted to it (could not be verified, though), so this PR (which is already implemented in our software for a while using my fork) gave us the opportunity to continue developing even in a (somewhat) unstable environment associated with open source code (which we absolutely love!).

[pratik-techholding]

Solution of @kfir4444 looks good can we approve this PR please many user facing issues

[kfir4444]

Thanks @pratik-techholding!
I do not think we should hate the code review process, if you want, you can use my clone until this PR is merge. I can ping you when it's merged 😄

[AurevoirXavier]

Maybe this could fix #9.

[ChrisCarini]

🎉 LGTM! Thank you for this change!

I'd be happy if this PR is merged as-is to simply unblock about a dozen or so of my repos' CI runs. The suggestion simply addresses @jlumbroso's question in their comment here; IMO, having messages printed for these command failures a 'nice-to-have', but not required. I'd rather see my CI jobs unblocked sooner rather than later.

@jlumbroso - by allowing this PR to be merged in and released, the below issues / PRs would be closed / addressed:

• 404 Not Found while removing packages #9
• Fix large packages aspnetcore #9 #11

Thoughts on getting this merged in to unblock the many CI runs that are affected by issues this PR addresses?

[yinweisu]

Hi, when do we expect to get the fix merged in? This issue is breaking my CI too

[ChrisCarini]

Hi @jlumbroso - do you have any subsequent concerns and/or blockers to getting this PR merged?

If you need extra help maintaining this repository, I'd be happy to volunteer to assist (I have experience with authoring & maintaining several GHAs); just let me know.

[kfir4444]

@jlumbroso as @ChrisCarini, I can also help with maintenance 😄

[kfir4444]

For everyone else struggling with issues, you can use my fork for now (this is what we do in our repos) until this chage becomes official. I can tag you here when this PR is merged so you can return to the original.
@AurevoirXavier @yinweisu @ChrisCarini

[causten]

Thanks for the replay @jlumbroso! 😃 Regarding your first question, I can think of some scenarios where this action could be used as a test, so a failure here could be important, but I think that the general use case only benefits from not stopping a CI due to failed deletion, which hinders development.

Don't you get for free the error check if you support "continue-on-error: true" in the action?

[Stephane-Ag]

This would also fix #4. I assume @jlumbroso has just not had a chance to look at this.

[jlumbroso]

Sorry for the delay. @ChrisCarini Thank you for addressing my concerns with your change.

[ChrisCarini]

Sorry for the delay.

No worries!

@ChrisCarini Thank you for addressing my concerns with your change.

Of course! FWIW, my offer to help you maintain this repo (ref: #8 (comment) ) (approving/merging PRs, releasing new versions, etc) still stands. :) Just let me know! Happy to help.