Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data uncompression at NimbleEmojiIndex constructor #45

Closed
wants to merge 3 commits into from
Closed

Fix data uncompression at NimbleEmojiIndex constructor #45

wants to merge 3 commits into from

Conversation

ekvedaras
Copy link

@ekvedaras ekvedaras commented Dec 7, 2018

uncompress function does not return anything. It manipulates data object instead. Therefore, after uncompression data becames undefined and index is empty

@serebrov
Copy link

serebrov commented Feb 9, 2019

Note that besides the NimbleEmojiIndex constructor, the uncompress is also called here - https://github.com/jm-david/emoji-mart-vue/blob/master/src/components/picker/nimblePicker.vue#L140

@serebrov serebrov mentioned this pull request Feb 9, 2019
@ekvedaras
Copy link
Author

Updated remaining usages I've found of uncompress

@meonaze meonaze mentioned this pull request Apr 15, 2019
@darivs
Copy link

darivs commented Apr 25, 2019

please merge

@deen13
Copy link

deen13 commented Apr 25, 2019

plleeeaaaaasssseee

@deen13
Copy link

deen13 commented Apr 25, 2019

I'd like some merge

@ekvedaras
Copy link
Author

This clearly dead and no longer relevant :)

@ekvedaras ekvedaras closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants