return data from uncompress method to fix issue #48 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to note, the return was removed recently in this pr #42 |
This was referenced Feb 9, 2019
Closed
|
Imo, PR #45 would be better approach than this as the data object is already mutated thus returning it will make no sense and will just add extra overhead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #48
In src/utils/emoji-index/nimble-emoji-index.js line 7, we assign the return value of the
uncompress(data)call to thedatavariable. But the named function has no return value.Because of this, the headless search is not functional. This quick fix should fix the issue.