Fixed compatibility issues with Python 3 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Luca, thanks so much for this contribution! I've been meaning to add python3 support for a while but never found the time as of yet. I'll test tomorrow morning and get it merged if everything checks out. |
|
Everything checks out & merged. Thanks again! |
|
Sure, no problem! Glad I could help 馃槈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
First of all, thanks for this package. It has saved me quite some time 馃槃
I've made a few changes (fixing imports and range/xrange issues) to make the project compatible with Python 3. In my tests, it runs with no problem under both 2 and 3.
I've also fixed some typos in the example in the read me file.
Best,
Luca