Skip to content

Commit

Permalink
use CPicture::CacheTexture rather than CreateThumbnailFromSurface for…
Browse files Browse the repository at this point in the history
… creating embedded video thumbs, so that future orientation info can be used
  • Loading branch information
Jonathan Marshall committed May 2, 2012
1 parent b6a2a22 commit 9ecf56f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion xbmc/cores/dvdplayer/DVDFileInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ bool CDVDFileInfo::ExtractThumb(const CStdString &strPath, const CStdString &str
dllSwScale.sws_scale(context, src, srcStride, 0, picture.iHeight, dst, dstStride);
dllSwScale.sws_freeContext(context);

CPicture::CreateThumbnailFromSurface(pOutBuf, nWidth, nHeight, nWidth * 4, strTarget);
CPicture::CacheTexture(pOutBuf, nWidth, nHeight, nWidth * 4, 0, 0, 0, strTarget);
bOk = true;
}

Expand Down

4 comments on commit 9ecf56f

@Memphiz
Copy link
Collaborator

@Memphiz Memphiz commented on 9ecf56f May 2, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The orientation info of videos is already in ^^ - future reached haha.

@jmarshallnz
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh - I can hook it up assuming it gets this far. Do you have a test video?

@Memphiz
Copy link
Collaborator

@Memphiz Memphiz commented on 9ecf56f May 2, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there are testmovies for each orientation on the teamftp under my folder.

@jmarshallnz
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, taken a look - unfortunately they don't decode for some odd reason, so I can't really hook it up anyway. The orientation mapping should be:

90 -> 5, 180 -> 2, 270 -> 7.

Please sign in to comment.