-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide custom constructor setting #96
Conversation
Hey @jmattheis, I gave this a shot, I hope it can help 🙂 Open points:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 97.47% 97.87% +0.39%
==========================================
Files 38 39 +1
Lines 1663 1693 +30
==========================================
+ Hits 1621 1657 +36
+ Misses 29 25 -4
+ Partials 13 11 -2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the contribution! I'll probably have a look at this tomorrow.
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed my remarks already. It was basically trial and error to a solution I was satisfied with.
@lampajr could you review the adjusted version? |
I just fixed a leftover in the doc (init --> default), it looks really great!! I tried it also locally in my use case, and it worked well 💪 |
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Good catch, thanks! |
Fixes #93
New feature: allow users to provide a custom
constructor
in order to initialize thetarget
obj.Usage:
Generated converter:
Tests:
Added some test scenarios under
/scenario
, all those matchingconstructor*.yml