-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attachments problems after Joomla updated to 3.4.4 #4
Comments
Please try this update (but unreleased) version:
Let me know that helps. -Jonathan On Sat, Sep 26, 2015 at 5:31 PM, Klipper notifications@github.com wrote:
|
Wow, you are fast. I will test the beta tomorrow on a backup of our site. |
I tested your attachments-3.2.4-Beta4.zip: Unfortunately issue 2 and 3 I reported are not fixed with the install of attachments-3.2.4-Beta4.zip. Also Issue 1 is still present on our online website. There was one new thing I discovered. The first issue only exist on our online site at Siteground. Adding new attachments from the article editor succeeded on my localhost version (= fresh backup from the online version) with Attachments 3.2.3 and also with the 3.2.4beta. Then I tested if lowering the php version at Siteground would solve the first issue. I changed the php version of the online site from 5.6.12 to 5.4.44. Allas, this php version change did not solve the first issue. So finally none of the issues online are solved. :-( |
Ok, I'll take a look. My time for this is limited,so please be patient. -Jonathan On Sun, Sep 27, 2015 at 7:42 AM, Klipper notifications@github.com wrote:
|
Hi, For the second issue I found a workaround, but it's not really a nice one. I've put the zip file, containing php files of an Joomla! extension, into a rar archive with a high compression. I could upload the rar file as an attachment now. But this cannot be a final solution of course. The third issue is still there. |
Thanks for the update. I hope to get a look at these issues this weekend. -Jonathan On Wed, Sep 30, 2015 at 1:27 PM, Klipper notifications@github.com wrote:
|
I also found reason of issue 3. It's triggered in the file 'javacript.php' at line 63 and 67, where you force to load the Mootools file 'modal.js' (JHtml::_('behavior.modal', 'a.modal-button');) on pages in the frontend containing attachments. I think it would be very nice if you change all Mootools dependencies to jQuery/Bootstrap dependecies within the Attachments extension, to get a better future-proof behavior of Attachments. Hope you can arrange that. Anyway, Attachments stay one of my favorite extensions! Thanks for creating and maintaining Attachments! |
Klipper, Ok. I think I have a fix to the upload problem (2). Please try this http://jmcameron.net/attachments/downloads/attachments-3.2.4-Beta5.zip Just install it over the old version (although I strongly encourage backing Please let me know if that helps. By the way, Joomla 3.4.0 added an option to the Joomla upload function to It make take a while to address the 3rd issue. Just changing from Mootools -Jonathan On Thu, Oct 1, 2015 at 4:17 AM, Klipper notifications@github.com wrote:
|
Sorry for the delay with testing your update of attachments 3.2.4-beta. I hope, you also can remove the Mootools dependency as soon as possible (change to jQuery). It's very annoying all these javascript errors because of conflicts between Mootools and jQuery. |
Ok! Glad that got one issue fixed. Yes, I do plan to convert to JQuery soon. Unfortunately, my time is very So please be patient... -Jonathan On Wed, Oct 28, 2015 at 6:41 PM, Klipper notifications@github.com wrote:
|
Hi, |
I'm afraid the problem is still not really solved.
As soon as I comment out line 31 in the script "javascript.php" Is there still no solution to the problem? |
Hi,
Since the update of Joomla 3.4.4 we have problems with attachments extension.
1.) Adding a new attachment fails from within the article editor screen (button below JCE). The button is present. Pushing the button shows the 'add attachments form', in which you can enter all properties and file to upload. Pushing the upload button, closes the page in the modal box, but no attachment appears below the article. When I look within the directory structure: after pushing the upload button, a directory with the name of the articleID has been created, but no uploaded files is in the directory (except the index.html).
So something goes wrong with uploading of the attachment from within the article editor. Same problem when trying to upload from the category editor. Directory gets created, but no uploaded files in the directory.
The only way I manage to add attachments to articles or categories is by opening the attachments componentscreen and choose the new button. Pushing the uploadbutton in the presented upload-form finally add the attachment to the chosen article or category.
2.) It seems there is a new safety feature within Joomla 3.4 which test uploaded files for malicious code. It test if the string '<?php' is within the file. When it's present the upload get canceled for security reasons. But the problem we have now that we cannot upload extensions as attachments anymore. Like a module or a plugin. Zips are extracted and the files are searched through and of course there are php files in an extensions .zip. I think we need a setting in attachments to overrule this security check. At least for administrators and super users from the backend.
3.) When I load an article in my browser containing one or more attachments a piece of Jquery script is added to the head of the page:
jQuery(function($) {
SqueezeBox.initialize({});
SqueezeBox.assign($('a.modal-button').get(), {
parse: 'rel'
});
});
function jModalClose() {
SqueezeBox.close();
}
Firebug reports an error:
ReferenceError: SqueezeBox is not defined
SqueezeBox.initialize({});
Hope you can fix these issues,
Regards,
Klipper
The text was updated successfully, but these errors were encountered: