Remove direct psycopg2 dependency and let user decide which to use #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jmcarp! Let me know if you have any thoughts on this one. |
|
As a user of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The psycopg2 dependency has gotten complicated due to a compatibility issue resulting in segfaults when using the binary-packaged version in some configurations. They removed the pre-compiled version from the default psycopg2 package, which had the side effect of making more difficult for the average end-user to install without having development libraries and a compiler installed.
There's a full explanation here: psycopg/psycopg2#674
Other dependent packages seem to be removing the transitive dependency and let the users decide which to use - e.g., sqlalchemy-redshift here: https://github.com/fizyk/sqlalchemy-redshift/commit/1781ff8d9dd8642c39ab8aefed61e9b08058e6e1
I have a package here that I'd like to use sqlalchemy-postgres-copy in (https://github.com/bluelabsio/records-mover), and I'd prefer not to vendor it in or add a psycopg2 dependency because of this, so I thought I'd send a PR your way. Let me know if it sounds right to you.
Fixes #12 but not in the same way proposed.