Add ability to use cards

[robert-bo-davis]

This adds rudimentary support for hipchat cards. Cards are much more extensible than the basic message format.

This maintains legacy behavior by default.

Here is the normal message, a collapsed card, an expanded card, and a collapsed failure:

[tboerger]

The code looks good so far, but now I know what you mean. Downstream is not really the correct icon reference

[jackspirou]

I need more time to really review this (I no longer use HipChat) but @mujiburger what do you think of having cards as the default behavior?

[robert-bo-davis]

I was worried about breaking somebody's custom templates for the original message style without telling them, but it doesn't look like that feature has been out for that long. Providing a disable_cards flag so there is an easy fix if somebody needs their original template and doesn't want to spend time figuring out the card templating may be enough. Let me know if that is the preferred behavior and I'll make it so.

Any input on the default card template would be appreciated. I went for less clutter in the collapsed card, but some may prefer more information without a click. The "activity" which is what shows before the card is expanded supports a pretty full subset of HTML so it is flexible.

[bradrydzewski]

If cards have different behavior, and different configuration, should they be two separate plugins? Perhaps a hipchat and hipchat_card plugin? I would rather have two plugins with simple configurations than a mono-plugin with many configuration options that is more difficult to understand.

[bradrydzewski]

btw, the card functionality looks awesome

[robert-bo-davis]

Since it is buried in the documentation updates of the PR, I wanted to make sure it was clear. As of right now, cards aren't supported on the hipchat mobile apps. The plugin sends both formats and those apps display the default message. A separate cards plugin would need to provide the same functionality as the main plugin in addition to handling cards.

[tboerger]

What should we do now? Migrate the drone config to 0.5 and merge this pr?

[bradrydzewski]

@tboerger I would prefer to accelerate efforts to create plugins.drone.io to allow developers to publish plugins or plugin variations

[tboerger]

@bradrydzewski so you want to close this PR?

[nlf]

code here lgtm

does need updated with master though, and also pending @bradrydzewski's decision here

[appleboy]

Any updates?

[jmccann]

@mujiburger I'm interested in supporting this. If you mind updating with the 0.5 updates I made I would totally review. Thanks!

[robert-bo-davis]

I took a quick look this morning. The conflict is strong with this one and I'm swamped at the moment. I'll take a harder look at it after the holidays.

[jmccann]

Yea, it was a major update to move to supporting Drone 0.5. Take your time!

[jmccann]

Just curious if/how refactoring this plugin to use some hipchat golang libraries would affect this effort? May make it easier?

Looking at potentially using either:

• https://github.com/tbruyelle/hipchat-go (seems like it may have some support for cards: https://github.com/tbruyelle/hipchat-go/blob/fc3453606408cfa87015e65ecb3309f9d1678317/hipchat/room.go#L74-L101)
• https://github.com/andybons/hipchat (may avoid this as I didn't see card stuff in it)

[jmccann]

Closing for now as I don't have time to update it and it seems to have gone stale.